Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change package name to ggfixest #29

Closed
grantmcdermott opened this issue Dec 4, 2023 · 10 comments · Fixed by #32
Closed

Change package name to ggfixest #29

grantmcdermott opened this issue Dec 4, 2023 · 10 comments · Fixed by #32

Comments

@grantmcdermott
Copy link
Owner

grantmcdermott commented Dec 4, 2023

With the addition of more general coefficient plot support (#28), it probably makes sense to change the package name to ggcoefplot (UPDATE: ggfixest) before submitting to CRAN.

PROS

  • Closer alignment with the upstream fixest docs and function logic, i.e. iplot is nested within coefplot as a special case.
  • Package functionality more immediately grok-able for those that come across it. (Most people understand what a "coefplot" is, whereas "iplot" is more insider baseball.)

CONS

  • A pain for backwards compatibility (albeit tempered by the fact that we haven't submitted to CRAN yet). Might make sense just to archive this repo in its current state as read only, leave a prominent note about the new repo location, and copy across the full version history to github.com/grantmcdermott/ggfixest.
  • Minor: 1) Will have to shuffle around some internal docs. 2) Will have to update a few external website links.
@grantmcdermott
Copy link
Owner Author

I'm leaning towards "yes", i.e. change the package name to "ggcoefplot" and then submit to CRAN.

Wondering if @lrberge or existing users have any thoughts/objections? @caleb-kwon @jcvdav @alexander-roth @simonheb

@lrberge
Copy link

lrberge commented Dec 4, 2023

Hi Grant, for me it seems that ggcoefplot is more explicit on what the function does. So maybe better?

@jcvdav
Copy link
Contributor

jcvdav commented Dec 4, 2023

Renaming to ggcoefplot seems logical.

@grantmcdermott
Copy link
Owner Author

grantmcdermott commented Dec 5, 2023

Another option: ggfixest

@jcvdav
Copy link
Contributor

jcvdav commented Dec 5, 2023

I'd stick to ggcoefplot, just in case you eventually decide to add support for making coefficient plots for other types of models.

@grantmcdermott
Copy link
Owner Author

Ha, ain't gonna happen!

In seriousness, I think other options like see already do a good job of providing generic coefficient plot support across many model classes. For me, as a dedicated fixest user, the benefit of this package lies in the additional features unlocked by this specific and tight integration.

@etiennebacher
Copy link

Just my 2 cents: I find ggcoefplot very generic and maybe a bit misleading if the end goal is to provide support only for fixest objects (which is completely fine for me, there are already several packages for plotting regression results).

I think ggfixest clearly sets the expectations: it provides ggplot2 support for fixest objects.

@grantmcdermott grantmcdermott changed the title Change package name to ggcoefplot Change package name to ggfixest Dec 8, 2023
@caleb-kwon
Copy link

Although my opinion should be significantly discounted since my knowledge of fixest and ggiplot is limited, I agree with @etiennebacher that ggfixest may be the most natural.

@grantmcdermott
Copy link
Owner Author

Thanks all.

End result: The package name has been changed to ggfixest and is now available on CRAN.

@etiennebacher
Copy link

Awesome, thanks @grantmcdermott !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants