Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using old anonymous function syntax #31

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

beniaminogreen
Copy link
Contributor

Hi there,

Thanks for writing such a fantastic package! I'm writing to ask if you would consider changing this line to use the older anonymous function syntax function(x){expression}.

The \(x) expression syntax is great, but it means that you can't install the package on machines with pre-2021 versions of R installed. Changing this line would mean that you are able to use the package on many more versions of R at the cost of tiny bit of expressiveness.

Best, and thanks for your help,
Ben

@grantmcdermott
Copy link
Owner

Thanks @beniaminogreen. I'm certainly happy to roll this PR into the main branch, but first I need to migrate the package name and repo (see #29). Hopefully this all goes smoothly and your PR is still left standing after migration...

@grantmcdermott grantmcdermott merged commit f55f0dc into grantmcdermott:main Dec 11, 2023
3 checks passed
@grantmcdermott
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants