Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Grant,
I'm the author of ggh4x and I am sunsetting the
ggh4x::guide_*()
family of functions.Because ggfixest uses
ggh4x::guide_axis_nested()
, this may cause problems for ggfixest.This PR replaces ggh4x's guides with legendry's guides, which is the successor of ggh4x's guides.
Unfortunately there is not a 1:1 translation from ggfixest's use case to an easy legendry guide, so it takes a little bit more wrangling to get the guide to display correctly.
Best wishes,
Teun