Support mixed normal/scaled graph in autoscale
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balancap
force-pushed
the
support-mixed-jax-scaled-graph-in-autoscale
branch
5 times, most recently
from
44f190e to
c9d4433
Compare
The `AutoScale` interpreter needs to be generalized to support mixed graph, where some tensors are still using normal JAX arrays. It means we need some form of rules + promotions related to: * When to use scaled primitives. By default, a `FORWARD` type rule, i.e. using scaled op if any input is scaled; * When to automatically promote simple arrays to ScaledArray. By default, just promoting scalars (maybe numpy constants in future?);
balancap
force-pushed
the
support-mixed-jax-scaled-graph-in-autoscale
branch
from
c9d4433 to
af7ade8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AutoScaleinterpreter needs to be generalized to support mixed graph, where some tensors are still using normal JAX arrays.It means we need some form of rules + promotions related to:
ScaledArray;ScaledArray;