Improve make_scaled_scalar with optional scale dtype parameter.
#93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allowing to pass directly the scale dtype (e.g. FP32) improves subnormal support, instead of flushing to zero.
balancap
force-pushed
the
improve-make_scaled_scalar-scale-dtype-and-denorm-support
branch
from
67baaa7 to
c7a0a96
Compare
balancap
deleted the
improve-make_scaled_scalar-scale-dtype-and-denorm-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing to pass directly the scale dtype (e.g. FP32) improves subnormal support, instead of flushing to zero.