Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Please include test suite in source release #2830

Open
niol opened this issue Feb 2, 2024 · 1 comment
Open

[BUG] Please include test suite in source release #2830

niol opened this issue Feb 2, 2024 · 1 comment
Labels
bug

Comments

@niol
Copy link
Contributor

niol commented Feb 2, 2024

Describe the bug
Source release does not include webapp/tests/.

Expected behavior
This makes is not possible to run the test suite when building from the source tarball.

Environment (please complete the following information):

  • OS flavor: all
  • Graphite-web version 1.1.10
  • Django/Python version all
  • Setup type sources and OS packages

Additional context
It would be handy to run the test suite in distributions CI infrastructures.

I'm not sure how releases are generated, but the following may be enough.

--- a/MANIFEST.in
+++ b/MANIFEST.in
@@ -8,5 +8,6 @@ include webapp/graphite/local_settings.py.example
 recursive-include distro/ *
 recursive-include webapp/graphite/ *.html
 recursive-include webapp/content/ *
+recursive-include webapp/tests/ *
 exclude webapp/graphite/local_settings.py
 exclude conf/*.conf
@niol niol added the bug label Feb 2, 2024
@deniszh
Copy link
Member

deniszh commented Aug 24, 2024

Make sense, will do

deniszh added a commit to deniszh/graphite-web that referenced this issue Aug 25, 2024
@deniszh
Include test suite in release (fixing graphite-project#2830)
893c45c
deniszh added a commit that referenced this issue Aug 25, 2024
@deniszh
Django 4.2 support (#2846)
66dcd48 
* Adding django-upgrade pre-commit

* Submitting django upgrade result

* Include test suite in release (fixing #2830)

* Fix pyparsing dep version (fixing #2834)

* Upgrade Django and python version in reqs and tox

* adding dependabot

* adding new python in tests

* Comment out broken tests

* fix attime tests for python 3.12

* fix more tests for python 3.12

* simplify tox

* fix self.assertRegex test

* fix self.assertRegex test

* fix self.assertEquals test

* pleasing linter

* more pleasing linter

* trying to fix events test

* let's keep doc on py310

* more event test fixes

* moving doc to 3.10

* ok, moving back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@deniszh @niol