Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat.Req] Regex message format during validation #46

Open
hopeyen opened this issue Aug 14, 2023 · 0 comments
Open

[Feat.Req] Regex message format during validation #46

hopeyen opened this issue Aug 14, 2023 · 0 comments
Labels
meta:triaged This issue has been triaged (has a good description, as well as labels for priority, size and type) p3 Low priority size:small Small type:refactor Changes not visible to users

Comments

@hopeyen
Copy link
Collaborator

hopeyen commented Aug 14, 2023

Problem statement

Protobuf decoding can successfully decode a message to a format that is different from the original format the message was sent in

Expectation proposal

On a message type level, add regex validation on the specialized inputs

  • Qm hash validation
  • bytes/hex validation
@hopeyen hopeyen added type:refactor Changes not visible to users size:small Small p3 Low priority labels Aug 14, 2023
@pete-eiger pete-eiger added the meta:triaged This issue has been triaged (has a good description, as well as labels for priority, size and type) label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta:triaged This issue has been triaged (has a good description, as well as labels for priority, size and type) p3 Low priority size:small Small type:refactor Changes not visible to users
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pete-eiger @hopeyen