fix: apply consistent mapping order _operatorAuth (OZ_N-05)

graphprotocol · Oct 4, 2024 · edc5c3e · edc5c3e
1 parent cb2da11
commit edc5c3e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/horizon/contracts/staking/HorizonStaking.sol b/packages/horizon/contracts/staking/HorizonStaking.sol
@@ -965,7 +965,7 @@ contract HorizonStaking is HorizonStakingBase, IHorizonStakingMain {
         if (_verifier == SUBGRAPH_DATA_SERVICE_ADDRESS) {
             _legacyOperatorAuth[msg.sender][_operator] = _allowed;
         } else {
-            _operatorAuth[msg.sender][_verifier][_operator] = _allowed;
+            _operatorAuth[msg.sender][_operator][_verifier] = _allowed;
         }
         emit OperatorSet(msg.sender, _operator, _verifier, _allowed);
     }
@@ -982,7 +982,7 @@ contract HorizonStaking is HorizonStakingBase, IHorizonStakingMain {
         if (_verifier == SUBGRAPH_DATA_SERVICE_ADDRESS) {
             return _legacyOperatorAuth[_serviceProvider][_operator];
         } else {
-            return _operatorAuth[_serviceProvider][_verifier][_operator];
+            return _operatorAuth[_serviceProvider][_operator][_verifier];
         }
     }
 }
diff --git a/packages/horizon/contracts/staking/HorizonStakingStorage.sol b/packages/horizon/contracts/staking/HorizonStakingStorage.sol
@@ -158,7 +158,7 @@ abstract contract HorizonStakingV1Storage {
 
     /// @dev Operator allow list
     /// Used for all verifiers except the subgraph data service.
-    mapping(address serviceProvider => mapping(address verifier => mapping(address operator => bool authorized)))
+    mapping(address serviceProvider => mapping(address operator => mapping(address verifier => bool authorized)))
         internal _operatorAuth;
 
     /// @dev Flag to enable or disable delegation slashing