Preserve sources of variable values #3811
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
yaacovCR
force-pushed
the
variable-value-sources-rebased
branch
from
89c7b8d
to
a24779c
Compare
yaacovCR
force-pushed
the
variable-value-sources-rebased
branch
from
a24779c
to
9e6cf99
Compare
|
I guess this should technically be a BREAKING CHANGE as the signature changes for |
yaacovCR
added
PR: breaking change 💥
mjmahone
reviewed
Jan 12, 2023
yaacovCR
force-pushed
the
variable-value-sources-rebased
branch
2 times, most recently
from
65145f9
to
ce33974
Compare
yaacovCR
force-pushed
the
variable-value-sources-rebased
branch
5 times, most recently
from
12f67c0
to
d8feffe
Compare
yaacovCR
force-pushed
the
variable-value-sources-rebased
branch
2 times, most recently
from
d8486ae
to
2211b7a
Compare
yaacovCR
force-pushed
the
variable-value-sources-rebased
branch
from
2211b7a
to
9f85bc3
Compare
yaacovCR
force-pushed
the
variable-value-sources-rebased
branch
from
9f85bc3
to
2906851
Compare
yaacovCR
force-pushed
the
variable-value-sources-rebased
branch
4 times, most recently
from
9dfe0a9
to
3d8be34
Compare
yaacovCR
force-pushed
the
variable-value-sources-rebased
branch
4 times, most recently
from
9e7a08b
to
12f30ec
Compare
yaacovCR
force-pushed
the
variable-value-sources-rebased
branch
5 times, most recently
from
5ee7a2f
to
2fe5343
Compare
Fixes graphql#3051 This change solves the problem of default values defined via SDL not always resolving correctly through introspection by preserving the original GraphQL literal in the schema definition. This changes argument and input field definitions `defaultValue` field from just the "value" to a new `GraphQLDefaultValueUsage` type which contains either -- but not both -- "value" and "literal" fields. Here is the flow for how a default value defined in an SDL would be converted into a functional schema and back to an SDL: **Before this change:** ``` (SDL) --parse-> (AST) --coerceInputLiteral--> (defaultValue config) --valueToAST--> (AST) --print --> (SDL) ``` `coerceInputLiteral` performs coercion which is a one-way function, and `valueToAST` is unsafe and set to be deprecated in graphql#3049. **After this change:** ``` (SDL) --parse-> (defaultValue literal config) --print --> (SDL) ```
By way of introducing type `VariableValues`, allows `getVariableValues` to return both the coerced values as well as the original sources, which are then made available in `ExecutionContext`.
yaacovCR
force-pushed
the
variable-value-sources-rebased
branch
from
2fe5343
to
55b9361
Compare
JoviDeCroock
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3077 rebased on main.
Depends on #3810
@leebyron comments from original PR: