Skip to content

Commit

Permalink
build: Do not install wasm-pack in buildboxes (#38533)
Browse files Browse the repository at this point in the history
Do not install wasm-pack in the buildboxes for v14 as we do not use wasm
on this branch. It is used for ironrdp which is v15+. This was perhaps
mistakenly backported to v14.
  • Loading branch information
camscale authored Feb 22, 2024
1 parent 96139da commit 3722a85
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 23 deletions.
4 changes: 0 additions & 4 deletions build.assets/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -220,10 +220,6 @@ RUN curl --proto '=https' --tlsv1.2 -fsSL https://sh.rustup.rs | sh -s -- -y --p
rustup component add rustfmt clippy && \
if [ "$BUILDARCH" = "amd64" ]; then rustup target add aarch64-unknown-linux-gnu; fi

ARG WASM_PACK_VERSION
# Install wasm-pack for targeting WebAssembly from Rust.
RUN cargo install wasm-pack --version ${WASM_PACK_VERSION}

# Switch back to root for the remaining instructions and keep it as the default
# user.
USER root
Expand Down
4 changes: 0 additions & 4 deletions build.assets/Dockerfile-centos7
Original file line number Diff line number Diff line change
Expand Up @@ -302,10 +302,6 @@ RUN curl --proto '=https' --tlsv1.2 -fsSL https://sh.rustup.rs | sh -s -- -y --p
cargo --version && \
rustc --version

ARG WASM_PACK_VERSION
# Install wasm-pack for targeting WebAssembly from Rust.
RUN cargo install wasm-pack --version ${WASM_PACK_VERSION}

# Do a quick switch back to root and copy/setup libfido2 and libpcsclite binaries.
# Do this last to take better advantage of the multi-stage build.
USER root
Expand Down
4 changes: 0 additions & 4 deletions build.assets/Dockerfile-centos7-fips
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,6 @@ RUN curl --proto '=https' --tlsv1.2 -fsSL https://sh.rustup.rs | sh -s -- -y --p
rustup component add rustfmt clippy && \
rustup target add ${TARGETARCH}-unknown-linux-gnu

ARG WASM_PACK_VERSION
# Install wasm-pack for targeting WebAssembly from Rust.
RUN cargo install wasm-pack --version ${WASM_PACK_VERSION}

ARG LIBBPF_VERSION
COPY --from=libbpf /opt/libbpf/usr /usr/libbpf-${LIBBPF_VERSION}

Expand Down
10 changes: 0 additions & 10 deletions build.assets/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,6 @@ buildbox:
--build-arg GOLANG_VERSION=$(GOLANG_VERSION) \
--build-arg GOLANGCI_LINT_VERSION=$(GOLANGCI_LINT_VERSION) \
--build-arg RUST_VERSION=$(RUST_VERSION) \
--build-arg WASM_PACK_VERSION=$(WASM_PACK_VERSION) \
--build-arg NODE_VERSION=$(NODE_VERSION) \
--build-arg LIBBPF_VERSION=$(LIBBPF_VERSION) \
--build-arg BUF_VERSION=$(BUF_VERSION) \
Expand Down Expand Up @@ -164,7 +163,6 @@ buildbox-centos7:
--build-arg TARGETARCH=$(HOST_ARCH) \
--build-arg GOLANG_VERSION=$(GOLANG_VERSION) \
--build-arg RUST_VERSION=$(RUST_VERSION) \
--build-arg WASM_PACK_VERSION=$(WASM_PACK_VERSION) \
--build-arg DEVTOOLSET=$(DEVTOOLSET) \
--build-arg LIBBPF_VERSION=$(LIBBPF_VERSION) \
--build-arg LIBPCSCLITE_VERSION=$(LIBPCSCLITE_VERSION) \
Expand All @@ -184,7 +182,6 @@ buildbox-centos7-fips:
--build-arg TARGETARCH=$(HOST_ARCH) \
--build-arg GOLANG_VERSION=$(GOLANG_VERSION) \
--build-arg RUST_VERSION=$(RUST_VERSION) \
--build-arg WASM_PACK_VERSION=$(WASM_PACK_VERSION) \
--build-arg DEVTOOLSET=$(DEVTOOLSET) \
--build-arg LIBBPF_VERSION=$(LIBBPF_VERSION) \
--cache-from $(BUILDBOX_CENTOS7_FIPS) \
Expand Down Expand Up @@ -538,13 +535,6 @@ print-buf-version:
print-rust-version:
@echo $(RUST_VERSION)

#
# Print the wasm-pack version used to build Teleport.
#
.PHONY:print-wasm-pack-version
print-wasm-pack-version:
@echo $(WASM_PACK_VERSION)

#
# Print the Node version used to build Teleport Connect.
#
Expand Down
1 change: 0 additions & 1 deletion build.assets/versions.mk
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ NODE_VERSION ?= 18.19.1

# Run lint-rust check locally before merging code after you bump this.
RUST_VERSION ?= 1.71.1
WASM_PACK_VERSION ?= 0.11.0
LIBBPF_VERSION ?= 1.2.2
LIBPCSCLITE_VERSION ?= 1.9.9-teleport

Expand Down

0 comments on commit 3722a85

Please sign in to comment.