Skip to content

Commit

Permalink
Remove ResetSessionRecordingConfig with incorrect return type (#38736)
Browse files Browse the repository at this point in the history
The cluster config RPC service had a typo in the return type of
ResetSessionRecordingConfig. Since our proto linter doesn't allow
renaming, this removes the RPC entirely so that it can be added
with the correct signature in a follow up. This service was only
recently introduced, and is not exposed in any way with the Auth
grpc server so removal is a safe operation.
  • Loading branch information
rosstimothy authored Feb 28, 2024
1 parent dd84c87 commit 76b9ab3
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 77 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ service ClusterConfigService {
rpc UpdateSessionRecordingConfig(UpdateSessionRecordingConfigRequest) returns (types.SessionRecordingConfigV2);
// UpsertSessionRecordingConfig overwrites the active session recording configuration.
rpc UpsertSessionRecordingConfig(UpsertSessionRecordingConfigRequest) returns (types.SessionRecordingConfigV2);
// ResetSessionRecordingConfig restores the active session recording configuration to default settings.
rpc ResetSessionRecordingConfig(ResetSessionRecordingConfigRequest) returns (types.ClusterNetworkingConfigV2);

// GetAuthPreference retrieves the active auth preference.
rpc GetAuthPreference(GetAuthPreferenceRequest) returns (types.AuthPreferenceV2);
Expand Down

0 comments on commit 76b9ab3

Please sign in to comment.