diff --git a/.golangci.yml b/.golangci.yml index 21894f78ba1f5..0bc4e7309cadf 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -61,6 +61,7 @@ issues: exclude-use-default: true max-same-issues: 0 max-issues-per-linter: 0 + uniq-by-line: false linters: disable-all: true @@ -270,9 +271,6 @@ linters-settings: - p: '^rsa\.GenerateKey$' msg: 'generating RSA keys is slow, use lib/cryptosuites to generate an appropriate key type' -output: - uniq-by-line: false - run: go: '1.23' build-tags: [] diff --git a/build.assets/versions.mk b/build.assets/versions.mk index fb33a21ba91df..6d20cc6e8c09e 100644 --- a/build.assets/versions.mk +++ b/build.assets/versions.mk @@ -4,7 +4,7 @@ # Sync with devbox.json. GOLANG_VERSION ?= go1.23.4 -GOLANGCI_LINT_VERSION ?= v1.61.0 +GOLANGCI_LINT_VERSION ?= v1.63.4 NODE_VERSION ?= 20.18.0 diff --git a/lib/integrations/awsoidc/eks_enroll_clusters_test.go b/lib/integrations/awsoidc/eks_enroll_clusters_test.go index 04e6c22f2d0e1..46e1ac8e169b3 100644 --- a/lib/integrations/awsoidc/eks_enroll_clusters_test.go +++ b/lib/integrations/awsoidc/eks_enroll_clusters_test.go @@ -170,7 +170,7 @@ func TestEnrollEKSClusters(t *testing.T) { responseCheck: func(t *testing.T, response *EnrollEKSClusterResponse) { require.Len(t, response.Results, 1) require.Equal(t, "EKS1", response.Results[0].ClusterName) - require.Empty(t, response.Results[0].Error) + require.NoError(t, response.Results[0].Error) require.Empty(t, response.Results[0].IssueType) require.NotEmpty(t, response.Results[0].ResourceId) }, @@ -187,7 +187,7 @@ func TestEnrollEKSClusters(t *testing.T) { return strings.Compare(a.ClusterName, b.ClusterName) }) require.Equal(t, "EKS1", response.Results[0].ClusterName) - require.Empty(t, response.Results[0].Error) + require.NoError(t, response.Results[0].Error) require.Empty(t, response.Results[0].IssueType) require.NotEmpty(t, response.Results[0].ResourceId) require.Equal(t, "EKS2", response.Results[1].ClusterName) diff --git a/lib/services/local/access_list_test.go b/lib/services/local/access_list_test.go index 887f09ad4467a..f1bac7e27535d 100644 --- a/lib/services/local/access_list_test.go +++ b/lib/services/local/access_list_test.go @@ -888,7 +888,7 @@ func TestAccessListReviewCRUD(t *testing.T) { // Verify that access lists reviews are gone. _, _, err = service.ListAccessListReviews(ctx, accessList1.GetName(), 0, "") - require.Empty(t, err) + require.NoError(t, err) } func TestAccessListRequiresEqual(t *testing.T) { diff --git a/lib/services/role_test.go b/lib/services/role_test.go index 6c86a86feecaf..8bde24cca2fed 100644 --- a/lib/services/role_test.go +++ b/lib/services/role_test.go @@ -1123,7 +1123,7 @@ func TestValidateRole(t *testing.T) { require.NoError(t, err, trace.DebugReport(err)) if len(tc.expectWarnings) == 0 { - require.Empty(t, warning) + require.NoError(t, warning) } for _, msg := range tc.expectWarnings { require.ErrorContains(t, warning, msg)