Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppServerOrSAMLIdPServiceProvider type deprecation and backport plan for Connect #39031

Closed
flyinghermit opened this issue Mar 6, 2024 · 1 comment · Fixed by #41047
Closed
Assignees

Comments

@flyinghermit
Copy link
Contributor

The #38709 PR deprecates KindAppOrSAMLIdPServiceProvider and AppServerOrSAMLIdPServiceProvider types.

The Web UI and Connect will still show SAML resource as "apps", we are only deprecating the usage of AppServerOrSAMLIdPServiceProvider in favor of processing types.AppServer and types.SAMLIdPServiceProvider individually in the Auth Service.

However, this is a breaking change for Connect (when Auth Service runs in v16 but Connect is on v15 current master) as the teleterm package used in Connect does not handle the types.SAMLIdPServiceProvider type. Though the teleterm package is updated in the same PR to recognize the types.SAMLIdPServiceProvider type, we need a backport/deprecation plan for Connect so it does not break when v16 is released.

The PR proposes to selectively backport teleterm package to v15. Since the v15 is fairly new, we can expect users to have been updated to latest v15.x by the time v16 is released.

The other option is to update Auth Service in v16 to respond with types based on client version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants