AWS OIDC: CreateEICE service #38548
Merged
AWS OIDC: CreateEICE service #38548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoandredinis
added
backport/branch/v14
no-changelog
Closed
|
@marcoandredinis am I the appropriate person to review this? I can review the general Go code/implementation itself, but I don't know anything about this work or how Teleport handles auth. |
|
I'll let bot pick a new set of reviewers 👍 |
marcoandredinis
force-pushed
the
marco/awsoidc-grpc-deployeice
branch
from
e6c53bd to
1d5afbd
Compare
nklaassen
approved these changes
Feb 27, 2024
Comment on lines
+259
to
+261
| if err := authCtx.CheckAccessToKind(types.KindIntegration, types.VerbUse); err != nil { | ||
| return nil, trace.Wrap(err) | ||
| } |
There was a problem hiding this comment.
Is this granular enough? I think as is, if the client can use any integration, they are allowed to create EICE endpoints?
I assume this will be called by the proxy which basically needs to be able to use any integration for now, but as we add new integrations I think it would be nice to give admins the power to restrict users to specific integrations something like
allow:
rules:
resources: [integration]
verbs: [use]
where: 'name == "example-integration"'I'll approve this PR since it's kind of tangential and there's already other endpoints that do the same, but I think it would be best to add server-side checking for this as early as we can so that supported auth versions are likely to check the where expressions whenever we eventually want to use them
There was a problem hiding this comment.
Totally agreed 👍
This was discussed in the RFD but we ended up with the most simple approach.
Even the use verb was not consensual.
#24256 (comment)
Honestly, I think we need to go even further.
We should support integration names and even integration actions.
To expand on your example:
allow:
rules:
resources: [integration]
verbs: [use]
where: 'name == "example-integration" && action == "awsoidc-create-eice"'I also agree that this PR should not be the one introducing that.
I'll keep this topic under my radar and possibly come up with a proposal.
marcoandredinis
force-pushed
the
marco/awsoidc-grpc-deployeice
branch
from
1d5afbd to
bf10f8e
Compare
AntonAM
approved these changes
Feb 28, 2024
public-teleport-github-review-bot
bot
removed request for
r0mant and
gabrielcorado
This PR creates a new method on the AWS OIDC gRPC service that deploys multiple EC2 Instance Connect Endpoints. This is part of a refactor that moves the API calls behind the Auth Service.
marcoandredinis
force-pushed
the
marco/awsoidc-grpc-deployeice
branch
from
bf10f8e to
b75a4c4
Compare
|
@marcoandredinis See the table below for backport results.
|
This was referenced Feb 28, 2024
marcoandredinis
added a commit
that referenced
this pull request
Feb 28, 2024
This PR creates a new method on the AWS OIDC gRPC service that deploys multiple EC2 Instance Connect Endpoints. This is part of a refactor that moves the API calls behind the Auth Service.
marcoandredinis
added a commit
that referenced
this pull request
Feb 28, 2024
This PR creates a new method on the AWS OIDC gRPC service that deploys multiple EC2 Instance Connect Endpoints. This is part of a refactor that moves the API calls behind the Auth Service.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
* AWS OIDC: List SecurityGroups service This PR creates a new method on the AWS OIDC gRPC service that lists SecurityGroups. This is part of a refactor that moves the API calls behind the Auth Service. * AWS OIDC: List EC2 service (#38326) This PR creates a new method on the AWS OIDC gRPC service that lists ec2 instances as Teleport Nodes. This is part of a refactor that moves the API calls behind the Auth Service. * AWS OIDC: List EICE service (#38332) * AWS OIDC: List EICE service This PR creates a new method on the AWS OIDC gRPC service that lists ec2 instance connect endpoints. This is part of a refactor that moves the API calls behind the Auth Service. * add required fields and aws api ref * add test * AWS OIDC: DeployService service (#38511) * AWS OIDC: DeployService service This PR creates a new method on the AWS OIDC gRPC service that deploys an ECS Service. This is part of a refactor that moves the API calls behind the Auth Service. * add rbac test and rename teleport config string * revert e * AWS OIDC: CreateEICE service (#38548) This PR creates a new method on the AWS OIDC gRPC service that deploys multiple EC2 Instance Connect Endpoints. This is part of a refactor that moves the API calls behind the Auth Service. * AWS OIDC: List EKS Clusters service (#38440) * AWS OIDC: List EKS Clusters service This PR creates a new method on the AWS OIDC gRPC service that lists eks clusters. This is part of a refactor that moves the API calls behind the Auth Service. * doc pb * AWS OIDC: Move enrollment of EKS clusters to the gRPC service. (#38683) This PR creates a new method on the AWS OIDC gRPC service that enrolls EKS clusters. This is part of a refactor that moves the API calls behind the Auth Service. --------- Co-authored-by: Anton Miniailo <anton@goteleport.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
* AWS OIDC: List SecurityGroups service This PR creates a new method on the AWS OIDC gRPC service that lists SecurityGroups. This is part of a refactor that moves the API calls behind the Auth Service. * AWS OIDC: List EC2 service (#38326) This PR creates a new method on the AWS OIDC gRPC service that lists ec2 instances as Teleport Nodes. This is part of a refactor that moves the API calls behind the Auth Service. * AWS OIDC: List EICE service (#38332) * AWS OIDC: List EICE service This PR creates a new method on the AWS OIDC gRPC service that lists ec2 instance connect endpoints. This is part of a refactor that moves the API calls behind the Auth Service. * add required fields and aws api ref * add test * AWS OIDC: DeployService service (#38511) * AWS OIDC: DeployService service This PR creates a new method on the AWS OIDC gRPC service that deploys an ECS Service. This is part of a refactor that moves the API calls behind the Auth Service. * add rbac test and rename teleport config string * revert e * AWS OIDC: CreateEICE service (#38548) This PR creates a new method on the AWS OIDC gRPC service that deploys multiple EC2 Instance Connect Endpoints. This is part of a refactor that moves the API calls behind the Auth Service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new method on the AWS OIDC gRPC service that deploys multiple EC2 Instance Connect Endpoints.
This is part of a refactor that moves the API calls behind the Auth Service.
Context: #37245