Teleport Kubernetes Operator supports Bot resource #40226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
hugoShaka,
klizhentas,
marcoandredinis,
ptgott,
r0mant,
tigrato,
xinding33 and
zmb3
|
So I think the biggest concern w/ this strategy is just ensuring that when we do generate this from the Proto, that it will result in a compatible struct to this handwritten one - that's the only thing in my mind that would prevent us moving forward with a workaround like this. |
carloscastrojumo
had a problem deploying
to
vercel
GitHub Actions
Failure
|
Hey @strideynet and @hugoShaka . The upstream issue (kubernetes/kubernetes#124154) still have no reply back from the team, so I'm bumping this again to check if you have any solution that we can implement here, or if we should implement my solution for now as I think this is a nice feature to have. Thanks |
carloscastrojumo
force-pushed
the
add-teleportbot-operator
branch
from
7a401dd to
117300b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #34285
As spoken with @hugoShaka and @strideynet, there seems to be an issue upstream (kubernetes/kubernetes#124154) when converting the CRD object into non exported fields, in this case some fields in BotSpec that were generated by protobuf.
The solution that I did temporarily to unlock my use case, was to convert the BotSpec struct from the TeleportBot, however this is not the ideal solution as it requires to maintain both structs. Im creating this PR so we can discuss as well a better alternative or just wait for the upstream issue.