increase app access max http request size to 70MiB #40242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GavinFrazar
force-pushed
the
gavinfrazar/raise-app-http-request-size-limit
branch
from
4733590 to
61d6e8b
Compare
GavinFrazar
commented
Apr 5, 2024
GavinFrazar
force-pushed
the
gavinfrazar/raise-app-http-request-size-limit
branch
from
61d6e8b to
d726669
Compare
GavinFrazar
changed the title
GavinFrazar
changed the title
GavinFrazar
force-pushed
the
gavinfrazar/raise-app-http-request-size-limit
branch
from
d726669 to
d1c9e69
Compare
github-actions
bot
added
database-access
greedy52
reviewed
Apr 8, 2024
greedy52
approved these changes
Apr 16, 2024
smallinsky
approved these changes
Apr 18, 2024
|
@GavinFrazar See the table below for backport results.
|
This was referenced Apr 20, 2024
GavinFrazar
added a commit
that referenced
this pull request
Apr 22, 2024
* increase app access max http request size to 70MB * move request body limiting into handlers * shim original behavior with custom reader wrappers * speed up aws handler tests
GavinFrazar
added a commit
that referenced
this pull request
Apr 22, 2024
* increase app access max http request size to 70MB * move request body limiting into handlers * shim original behavior with custom reader wrappers * speed up aws handler tests
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
* increase app access max http request size to 70MiB (#40242) * increase app access max http request size to 70MB * move request body limiting into handlers * shim original behavior with custom reader wrappers * speed up aws handler tests * fix imports for backport
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
* increase app access max http request size to 70MiB (#40242) * increase app access max http request size to 70MB * move request body limiting into handlers * shim original behavior with custom reader wrappers * speed up aws handler tests * fix imports for backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: Fixed an issue that prevented uploading a zipfile larger than 10MiB when updating an AWS Lambda function via tsh app access.
AWS limits lambda function zip file upload to 50MiB, but base64 encodes the body so the actual request size maximum is around ~70MiB. Anything bigger than that, they should just use s3 upload.
I decoupled app access request size limiting from other services by pulling the size limit out of our http utils.