Convert tsh recursive listing to connect to Proxy via gRPC #40268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
added
the
no-changelog
rosstimothy
changed the title
rosstimothy
force-pushed
the
tross/tsh_get_clusters
branch
from
47eaf5a to
f121a1b
Compare
rosstimothy
changed the base branch from
master
to
tross/proxy_client_tls_config
rosstimothy
force-pushed
the
tross/tsh_get_clusters
branch
from
78f4a35 to
d4f0698
Compare
rosstimothy
force-pushed
the
tross/proxy_client_tls_config
branch
from
d2c7859 to
4c6e970
Compare
rosstimothy
force-pushed
the
tross/tsh_get_clusters
branch
from
d4f0698 to
bab8c51
Compare
rosstimothy
force-pushed
the
tross/proxy_client_tls_config
branch
from
4c6e970 to
22031f9
Compare
rosstimothy
force-pushed
the
tross/tsh_get_clusters
branch
from
bab8c51 to
ad29492
Compare
github-actions
bot
added
size/sm
tctl
nklaassen
approved these changes
Apr 10, 2024
| group.Go(func() error { | ||
| kc, err := kubeutils.ListKubeClustersWithFilters(groupCtx, cluster.auth, cluster.req) | ||
| if err != nil { | ||
| logrus.Errorf("Failed to get kube clusters: %v.", err) |
There was a problem hiding this comment.
I'm a bit confused since you're the slog guy, shouldn't we be using slog for new logs? Looks like this is the only logrus ref in this file
There was a problem hiding this comment.
slog guy 😅
I went with logrus because none of our client binaries are using slog yet and TBH I didn't realize this was the first time it was being referenced in this file. I guess now is as good a time as any to start making the switch.
EdwardDowling
approved these changes
Apr 11, 2024
|
/excludeflake * |
Removes deprecated usage of ProxyClient in getClusterClients used for tsh ls -R and tsh db ls -R.
rosstimothy
force-pushed
the
tross/tsh_get_clusters
branch
from
ad29492 to
e2f6c94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates all tsh recursive listing operations off of the deprecated ProxyClient in favor of the ClusterClient.
Updates #38239