Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log information about second_factors removal at startup #41416

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

lxea
Copy link
Contributor

@lxea lxea commented May 10, 2024

Update to make it clearer why teleport isnt starting when trying to upgrade

@lxea lxea assigned r0mant and zmb3 May 10, 2024
@github-actions github-actions bot requested review from GavinFrazar and kimlisa May 10, 2024 16:42
@gravitational gravitational deleted a comment from github-actions bot May 10, 2024
@lxea lxea added the no-changelog Indicates that a PR does not require a changelog entry label May 10, 2024
@lxea lxea unassigned r0mant and zmb3 May 10, 2024
@lxea lxea requested review from r0mant and zmb3 and removed request for GavinFrazar and kimlisa May 10, 2024 16:46
lib/auth/init.go Show resolved Hide resolved
@lxea lxea requested a review from zmb3 May 22, 2024 12:37
lib/auth/init.go Outdated Show resolved Hide resolved
lib/auth/init.go Outdated Show resolved Hide resolved
lib/modules/modules.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with Zac's comments addressed

@lxea lxea enabled auto-merge May 23, 2024 11:09
@lxea lxea requested a review from zmb3 June 4, 2024 11:33
@lxea lxea force-pushed the lxea/2fa-upgrade-message branch from 4d572b9 to 199294f Compare June 4, 2024 11:34
@lxea lxea added this pull request to the merge queue Jun 5, 2024
Merged via the queue into master with commit 72f4a10 Jun 5, 2024
37 checks passed
@lxea lxea deleted the lxea/2fa-upgrade-message branch June 5, 2024 21:15
@public-teleport-github-review-bot

@lxea See the table below for backport results.

Branch Result
branch/v16 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v16 no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants