Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix The source data has been detached error #41492

Merged
merged 2 commits into from
May 13, 2024

Conversation

probakowski
Copy link
Contributor

@probakowski probakowski commented May 13, 2024

Sometimes Desktop session stops with The source data has been detached, this change fixes that by checking if we have any data to actually render.
This problem shows up more on Windows 2019 than 2022.

changelog: Fixed an error that could prevent Windows desktop sessions from rendering the remote session.

Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@probakowski probakowski enabled auto-merge May 13, 2024 21:08
@probakowski probakowski added this pull request to the merge queue May 13, 2024
Merged via the queue into master with commit bb1a287 May 13, 2024
37 checks passed
@probakowski probakowski deleted the probakowski/fix-putimagedata branch May 13, 2024 21:25
@public-teleport-github-review-bot

@probakowski See the table below for backport results.

Branch Result
branch/v15 Create PR

zmb3 added a commit that referenced this pull request Sep 21, 2024
We need to check the length of the image data to avoid errors.
This was originally fixed in #41492 but regressed in the refactor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants