-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: Add support for jamf_service to the teleport-kube-agent Helm chart #42368
helm: Add support for jamf_service to the teleport-kube-agent Helm chart #42368
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For v16+ we should be pushing folks toward using client ID and client secret instead of username and password. cc @codingllama
🤖 Vercel preview here: https://docs-m06cobads-goteleport.vercel.app/docs/ver/preview |
+1, please add fields for client ID and client secret, and document that these are preferred over username/password. All that is required already landed for v16 (see #41928 or public docs for reference). |
If we're going to ship this PR in v16, we can even remove the user/password fields so folks have to use client ID/secret. |
🤖 Vercel preview here: https://docs-3y9wt21dm-goteleport.vercel.app/docs/ver/preview |
Currently both auth methods are supported. If keeping only Client Credentials is preferred, I'm happy to remove it. |
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
@lcharkiewicz do we need this chart for any versions prior to v16? If no, then let's eliminate the user/password entirely and just ship the client credentials. That would simplify the chart a bit since the jamf client credentials are only supported on v16. |
Co-authored-by: Hugo Shaka <hugo.hervieux@goteleport.com>
🤖 Vercel preview here: https://docs-ioxcmqfsp-goteleport.vercel.app/docs/ver/preview |
🤖 Vercel preview here: https://docs-g1hd4tdsg-goteleport.vercel.app/docs/ver/preview |
@rosstimothy I thought my team might need it with v15. After a discussion we decided that we can go with v16 only. Thus, I dropped the support for Jamf username and password auth (and yes, I like the simpler code now :)). |
@hugoShaka your suggestions have been addressed, PTAL. |
🤖 Vercel preview here: https://docs-730x5znld-goteleport.vercel.app/docs/ver/preview |
@lcharkiewicz See the table below for backport results.
|
This PR adds support for
jamf_service
configuration to theteleport-kube-agent
Helm chart.The change supports Jamf API Client Credentials auth method available in Teleport v16+
More about the required configuration can be found in the official Teleport docs.
Additional Jamf service options, like
sync_period_*
orfilter_rsql
can be configured by settingteleportConfig
.changelog: helm: add support for jamf_service to teleport-kube-agent