Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v16] Allow athenaevents to bypass SNS #42463

Merged
merged 2 commits into from
Jun 5, 2024
Merged

[v16] Allow athenaevents to bypass SNS #42463

merged 2 commits into from
Jun 5, 2024

Conversation

espadolini
Copy link
Contributor

Backport #42275 to branch/v16

@espadolini espadolini added the no-changelog Indicates that a PR does not require a changelog entry label Jun 4, 2024
@espadolini espadolini marked this pull request as ready for review June 4, 2024 23:41
@github-actions github-actions bot requested review from nklaassen and smallinsky June 4, 2024 23:41
@github-actions github-actions bot added audit-log Issues related to Teleports Audit Log backport size/md labels Jun 4, 2024
@espadolini
Copy link
Contributor Author

Manually tested, regular SNS and direct to SQS have the same behavior; a test failed in the exact same way, that didn't fail on master:

=== RUN   TestIntegrationAthenaSessionEventsCRUD
=== RUN   TestIntegrationAthenaSessionEventsCRUD/sns
    test.go:230: Initialized Athena test suite "auditlogs-integrationtests-1811237a-c1af-4180-bfac-cdd2ac72d743"
    suite.go:354: 
                Error Trace:    /Users/espadolini/src/teleport/lib/events/test/suite.go:354
                                                        /Users/espadolini/src/teleport/lib/events/athena/integration_test.go:93
                                                        /Users/espadolini/src/teleport/lib/events/athena/integration_test.go:71
                Error:          "[Metadata:<Type:"user.login" ID:"94acbf87-2a34-46a8-b0e0-925bee791174" Time:<seconds:1717545403 nanos:272959000 > > User:<User:"bob" > Status:<Success:true > Method:"saml" Client:<> Connection:<>  Metadata:<Type:"session.start" ID:"cc46d014-b0e1-4f55-9f84-8e7c566cf5a2" Time:<seconds:1717545463 nanos:272959000 > > User:<Login:"bob" > Session:<SessionID:"55446bb0-0a74-45c1-be29-371e56e7049e" > Server:<> Connection:<> KubernetesCluster:<> KubernetesPod:<> ]" should have 3 item(s), but has 2
                Test:           TestIntegrationAthenaSessionEventsCRUD/sns
=== RUN   TestIntegrationAthenaSessionEventsCRUD/sqs
    test.go:230: Initialized Athena test suite "auditlogs-integrationtests-8903d7ec-5a01-4216-8509-2034c226b07d"
    suite.go:354: 
                Error Trace:    /Users/espadolini/src/teleport/lib/events/test/suite.go:354
                                                        /Users/espadolini/src/teleport/lib/events/athena/integration_test.go:93
                                                        /Users/espadolini/src/teleport/lib/events/athena/integration_test.go:75
                Error:          "[Metadata:<Type:"user.login" ID:"11df3621-a6d4-4509-b607-21efdd4c0173" Time:<seconds:1717545441 nanos:494298000 > > User:<User:"bob" > Status:<Success:true > Method:"saml" Client:<> Connection:<>  Metadata:<Type:"session.start" ID:"39ce628d-2c30-4369-8f17-b511fc17e457" Time:<seconds:1717545501 nanos:494298000 > > User:<Login:"bob" > Session:<SessionID:"a12e99dd-ba36-4ecc-b1d4-1da34b4f43a5" > Server:<> Connection:<> KubernetesCluster:<> KubernetesPod:<> ]" should have 3 item(s), but has 2
                Test:           TestIntegrationAthenaSessionEventsCRUD/sqs
--- FAIL: TestIntegrationAthenaSessionEventsCRUD (76.44s)
    --- FAIL: TestIntegrationAthenaSessionEventsCRUD/sns (38.46s)
    --- FAIL: TestIntegrationAthenaSessionEventsCRUD/sqs (37.97s)

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from nklaassen June 5, 2024 07:58
@espadolini espadolini added this pull request to the merge queue Jun 5, 2024
Merged via the queue into branch/v16 with commit fb46701 Jun 5, 2024
40 checks passed
@espadolini espadolini deleted the bot/backport-42275-branch/v16 branch June 5, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smallinsky smallinsky smallinsky approved these changes

@marcoandredinis marcoandredinis marcoandredinis approved these changes

Assignees
No one assigned
Labels
audit-log Issues related to Teleports Audit Log backport no-changelog Indicates that a PR does not require a changelog entry size/md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@espadolini @marcoandredinis @smallinsky