Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accesslist: return "ineligible_status" for all write operations #42474

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

tigrato
Copy link
Contributor

@tigrato tigrato commented Jun 5, 2024

This PR propagates access list members and owner's ineglibile_status field with the data from the backend. Prior to this change, the field was ignored.

This PR propagates access list members and owner's ineglibile_status
field with the data from the backend. Prior to this change, the field
was ignored.

Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
@tigrato tigrato added backport/branch/v14 no-changelog Indicates that a PR does not require a changelog entry backport/branch/v15 backport/branch/v16 labels Jun 5, 2024
@tigrato tigrato requested a review from smallinsky June 5, 2024 11:16
@github-actions github-actions bot requested review from atburke and nklaassen June 5, 2024 11:16
Copy link
Contributor

@smallinsky smallinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Just cc @kimlisa to ensure that FE doesn't have any weird corner cases when the eligibility is returned from write/update operation.

@tigrato tigrato added this pull request to the merge queue Jun 5, 2024
Merged via the queue into master with commit c09f2c0 Jun 5, 2024
40 checks passed
@tigrato tigrato deleted the tigrato/populate-access-list-owner-member branch June 5, 2024 12:07
@public-teleport-github-review-bot

@tigrato See the table below for backport results.

Branch Result
branch/v14 Create PR
branch/v15 Create PR
branch/v16 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants