Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public IP address allowlist for Teleport Cloud #42593

Merged
merged 11 commits into from
Jun 10, 2024
Merged

Conversation

sclevine
Copy link
Member

@sclevine sclevine commented Jun 6, 2024

This PR adds an allowlist of public IP addresses for Teleport Cloud to the Teleport Cloud sections of the docs.

This implements the IP management policy described here (internal link).

Copy link

github-actions bot commented Jun 6, 2024

🤖 Vercel preview here: https://docs-g33b3q47r-goteleport.vercel.app/docs/ver/preview

@sclevine sclevine marked this pull request as ready for review June 7, 2024 17:41
@sclevine sclevine requested review from ptgott and ravicious June 7, 2024 21:16
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

Copy link

🤖 Vercel preview here: https://docs-gamlhfkmb-goteleport.vercel.app/docs/ver/preview

Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@sclevine sclevine added documentation no-changelog Indicates that a PR does not require a changelog entry labels Jun 10, 2024
Copy link

🤖 Vercel preview here: https://docs-d62pjvca6-goteleport.vercel.app/docs/ver/preview

tocDepth: 3
---

Teleport Agents connected to Teleport Enterprise Cloud must be allowed to connect to the following IP addresses in order to join the Teleport cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Teleport Agents connected to Teleport Enterprise Cloud must be allowed to connect to the following IP addresses in order to join the Teleport cluster.
Teleport Agents connected to managed Teleport Enterprise accounts must be allowed to connect to the following IP addresses in order to join the Teleport cluster.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went with "cloud-hosted" for consistency with the other wording. It's important that self-hosted customers understand that this is not necessary (and less secure) for their setup.

docs/pages/choose-an-edition/teleport-cloud/ips.mdx Outdated Show resolved Hide resolved
docs/pages/choose-an-edition/teleport-cloud/ips.mdx Outdated Show resolved Hide resolved
</Notice>

When this list is modified, we will provide at least two weeks notice by:
1. Updating the Changelog below.
Copy link
Contributor

@ptgott ptgott Jun 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will this look like during the next update? For an update two weeks from today, would it look like:

- 2024-06-24: List updated
- 2024-06-06: List published

If updating the docs is part of the IP allowlist update workflow, would it make sense to include a Notice containing the date of the next allowlist update at the top of the page instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be more descriptive, and less frequent, e.g.,

- 2026-06-24: 127.1.2.3/32 added to list.
- 2024-06-06: List published

Example of a similar workflow: https://www.cloudflare.com/ips/

would it make sense to include a Notice containing the date of the next allowlist update at the top of the page instead

For security and process reasons, nothing needs to be announced before the list is updated. We could add a notice when we update the list, to call attention to the recent change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, thanks!

Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
Copy link

🤖 Vercel preview here: https://docs-dgqemojqr-goteleport.vercel.app/docs/ver/preview

Copy link

🤖 Vercel preview here: https://docs-58ajv1w57-goteleport.vercel.app/docs/ver/preview

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from ravicious June 10, 2024 19:49
Copy link

🤖 Vercel preview here: https://docs-odzdftr6j-goteleport.vercel.app/docs/ver/preview

Copy link

🤖 Vercel preview here: https://docs-kftkxf3z5-goteleport.vercel.app/docs/ver/preview

@sclevine sclevine enabled auto-merge June 10, 2024 19:54
@sclevine sclevine added this pull request to the merge queue Jun 10, 2024
Copy link

🤖 Vercel preview here: https://docs-6gfc52yvo-goteleport.vercel.app/docs/ver/preview

Merged via the queue into master with commit c7b4698 Jun 10, 2024
37 checks passed
@sclevine sclevine deleted the sclevine/cloud-ips branch June 10, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v15 backport/branch/v16 documentation no-changelog Indicates that a PR does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants