-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v16] Fix docs markup errors #42603
[v16] Fix docs markup errors #42603
Conversation
Going to create a buddy PR for this |
Hey. What are our next steps on these PRs? I see approvals, but some of the CI task are still falling and also @ptgott wrote that he wants to create buddy PRs for them. What needs to do what next to make these changes merged |
External contributions are unable to be accepted directly because CI will not run. @ptgott opened a "buddy" PR which will be merged to master, and then backported to branch/v16, branch/v15, and branch/v14. You will retain authorship of your commits. I'll close this for now to eliminate confusion. |
@rosstimothy got it! |
@iAdramelk feel free to close those PRs. @ptgott will take care of backporting the changes to release branches after they land in master. |
@rosstimothy I will close them for now. JFY, they have different set of changes. Some changes which were needed for the older versions are not needed in master and vice versa. |
Update of #42512 based on v16 branch. These changes should also be backported to
master
.Some fixes for the docs to fix validation errors and warnings in Docusaurus:
.mdx
extension to links to make possible to validate links.docs/pages/access-controls/access-request-plugins/servicenow.mdx
inline code.docs/pages/reference/terraform-provider.mdx
that was causing mdx failing. (But this is an auto-generated file, so it's better to fix it in the original location too).dbname
key fortctl-auth-sign-3-files.mdx
includes to make them work.Didn't fix, but should be fixed separately:
includes/dynamodb-iam-policy.mdx
inCHANGELOG.md
– files in includes folder does not build to full pages in docs./docs/img/database-access/guides/cloudsql/instance-id@2x.png
/docs/img/database-access/guides/cloudsql/instance-public-ip@2x.png
/docs/img/desktop-access/install-active-directory.png