Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[buddy] Fix docs markup errors #43223

Merged
merged 1 commit into from
Jun 20, 2024
Merged

[buddy] Fix docs markup errors #43223

merged 1 commit into from
Jun 20, 2024

Conversation

ptgott
Copy link
Contributor

@ptgott ptgott commented Jun 18, 2024 •
edited by codingllama
Loading

Buddy PR for #42603, #42510, and #42509.

@github-actions GitHub Actions
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@ptgott
Copy link
Contributor Author

ptgott commented Jun 18, 2024

This is a buddy PR for #42603, #42510, and #42509.

Once this is is merged, I'll backport it to versions 16, 15, and 14, closing the following buddy backports:

@ptgott ptgott mentioned this pull request Jun 18, 2024
Closed
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-9nzk6q0u7-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

1 similar comment
@github-actions GitHub Actions
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

codingllama
codingllama approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@codingllama codingllama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Paul and @iAdramelk!

@github-actions GitHub Actions
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

This was referenced Jun 19, 2024
Closed
Closed
@codingllama codingllama added the no-changelog Indicates that a PR does not require a changelog entry label Jun 19, 2024
@rosstimothy rosstimothy mentioned this pull request Jun 20, 2024
Closed
@ptgott ptgott added this pull request to the merge queue Jun 20, 2024
Merged via the queue into master with commit b9bacef Jun 20, 2024
39 of 44 checks passed
@ptgott ptgott deleted the paul.gottschling/2024-06-fix-markup-errors branch June 20, 2024 16:56
@public-teleport-github-review-bot
Copy link

@ptgott See the table below for backport results.

Branch Result
branch/v14 Failed
branch/v15 Create PR
branch/v16 Create PR

This was referenced Jun 20, 2024
Merged
Merged
ptgott added a commit that referenced this pull request Jun 20, 2024
@ptgott @iAdramelk
[v14] Fix docs markup errors
ae0b4fc 
Backports #43223

Co-authored-by: Alexey Ivanov <mail@alexeyivanov.info>
@ptgott ptgott mentioned this pull request Jun 20, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jun 20, 2024
@ptgott @iAdramelk
[v14] Fix docs markup errors (#43316)
545fe48 
Backports #43223

Co-authored-by: Alexey Ivanov <mail@alexeyivanov.info>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingllama codingllama codingllama approved these changes

@greedy52 greedy52 greedy52 approved these changes

Assignees
No one assigned
Labels
backport/branch/v14 backport/branch/v15 backport/branch/v16 documentation no-changelog Indicates that a PR does not require a changelog entry size/md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ptgott @greedy52 @codingllama @iAdramelk