Check if binary exists before passing it to node-pty #44440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravicious
commented
Jul 19, 2024
| // start, it's reported through PtyProcess.prototype.onStartError. Similarly, the information | ||
| // about a successful start is also conveyed through an emitted event rather than the method | ||
| // returning with no error. Hence why we can ignore what this promise returns. | ||
| void this.ptyProcess.start(event.columns, event.rows).then(() => { |
There was a problem hiding this comment.
I'm using the syntax recommended by no-floating-promises to explicitly mark a promise that we ignore. https://typescript-eslint.io/rules/no-floating-promises/#ignorevoid
ryanclark
approved these changes
Jul 19, 2024
gzdunek
approved these changes
Jul 19, 2024
| @@ -30,6 +30,7 @@ | |||
| "split2": "4.2.0", | |||
| "strip-ansi": "^7.1.0", | |||
| "tar-fs": "^3.0.6", | |||
| "which": "^4.0.0", | |||
There was a problem hiding this comment.
I know it's a small package, but maybe we could add @types/which?
There was a problem hiding this comment.
Done, mostly to check out the flow of adding a new package with pnpm. ;)
ravicious
force-pushed
the
r7s/check-pty-exe
branch
from
bc185d7 to
ad7d66f
Compare
|
@ravicious See the table below for backport results.
|
This was referenced Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44385.
At some point between 0.11.0-beta29 to 1.1.0-beta5, node-pty stopped throwing errors on Linux and macOS if the command to execute doesn't exist (microsoft/node-pty#689). Instead, the PTY simply exits with error code 1.
This PR makes it so that we manually run the equivalent of Go's
os/exec.LookPathbefore starting a terminal session. This way we can bubble up the error about a nonexistent command to the UI.changelog: Fixed terminal sessions with a database CLI client in Teleport Connect hanging indefinitely if the client cannot be found