Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14] Update lint action to catch any untidy go module #44457

Merged
merged 1 commit into from
Jul 19, 2024
Merged

[v14] Update lint action to catch any untidy go module #44457

merged 1 commit into from
Jul 19, 2024

Conversation

rosstimothy
Copy link
Contributor

Backport #44392 to branch/v14

@rosstimothy
Update lint action to catch any untidy go module (#44392)
b91ad2a 
* Update lint action to catch any untidy go module

Due to integrations/terraform and integrations/event-handler
importing teleport and replacing with ../.. any updates to
go.mod need to be kept in sync with the integrations modules.
The go mod tidiness check in the lint step only compared teleport
and the api modules, which allowed things to get out of sync and
possibly break integrations builds. The tidiness check now validates
that any go module in the repository is tidy.
@rosstimothy rosstimothy added backport no-changelog Indicates that a PR does not require a changelog entry labels Jul 19, 2024
@rosstimothy rosstimothy marked this pull request as ready for review July 19, 2024 13:49
@rosstimothy rosstimothy requested a review from codingllama July 19, 2024 15:23
@rosstimothy rosstimothy enabled auto-merge July 19, 2024 15:23
@rosstimothy rosstimothy added this pull request to the merge queue Jul 19, 2024
Merged via the queue into branch/v14 with commit e4ceb0f Jul 19, 2024
28 of 29 checks passed
@rosstimothy rosstimothy deleted the tross/backport-44392/v14 branch July 19, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingllama codingllama codingllama approved these changes

@r0mant r0mant r0mant approved these changes

@klizhentas klizhentas Awaiting requested review from klizhentas klizhentas is a code owner

@russjones russjones Awaiting requested review from russjones russjones is a code owner

@zmb3 zmb3 Awaiting requested review from zmb3 zmb3 is a code owner

@fheinecke fheinecke Awaiting requested review from fheinecke fheinecke is a code owner

@camscale camscale Awaiting requested review from camscale camscale is a code owner

@tcsc tcsc Awaiting requested review from tcsc tcsc is a code owner

Assignees
No one assigned
Labels
backport no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rosstimothy @r0mant @codingllama