Add cluster autoupdate resources with enabled cache #45617
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| // Copyright 2024 Gravitational, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package autoupdate | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| "github.com/gravitational/trace" | ||
|
|
||
| "github.com/gravitational/teleport/api/gen/proto/go/teleport/autoupdate/v1" | ||
| ) | ||
|
|
||
| // Client is an AutoupdateService client that conforms to the following lib/services interfaces: | ||
| // - services.AutoupdateService | ||
| type Client struct { | ||
|
There was a problem hiding this comment. Do we need a dedicated client? There isn't much going on here besides hiding gRPC requests. Consider following the same approach that Noah took with the SPIFFE resource: There was a problem hiding this comment. in codebase there are 3 ways how it is implemented, legacy one with interface in types, methods implementation and this one with wrapping grpc client to be interface compatible to service definition, this PR by iterations implemented all of them. Last one was added because I was trying to eliminate methods declarations for client (as it was requested previously in this review) and use only client wrapper: but its not possible right now because if we use cache wrapping, interfaces of the interface ReadRemoteProxyAccessPoint {
GetAutoupdateConfig(ctx context.Context) (*autoupdate.AutoupdateConfig, error)
GetAutoupdateVersion(ctx context.Context) (*autoupdate.AutoupdateVersion, error)
}
type RemoteProxyAccessPoint interface {
ReadRemoteProxyAccessPoint
accessPoint
}
func NewRemoteProxyWrapper(base RemoteProxyAccessPoint, cache ReadRemoteProxyAccessPoint) RemoteProxyAccessPoint {...}
// newLocalCacheForRemoteProxy returns new instance of access point configured for a remote proxy.
func (process *TeleportProcess) newLocalCacheForRemoteProxy(clt authclient.ClientI, cacheName []string) (authclient.RemoteProxyAccessPoint, error) {
// if caching is disabled, return access point
if !process.Config.CachePolicy.Enabled {
return clt, nil
}
cache, err := process.NewLocalCache(clt, cache.ForRemoteProxy, cacheName)
if err != nil {
return nil, trace.Wrap(err)
}
return authclient.NewRemoteProxyWrapper(clt, cache), nil
} |
||
| grpcClient autoupdate.AutoupdateServiceClient | ||
| } | ||
|
|
||
| // NewClient creates a new AutoupdateService client. | ||
| func NewClient(grpcClient autoupdate.AutoupdateServiceClient) *Client { | ||
| return &Client{ | ||
| grpcClient: grpcClient, | ||
| } | ||
| } | ||
|
|
||
| // GetAutoupdateConfig returns the specified AutoupdateConfig resource. | ||
| func (c *Client) GetAutoupdateConfig(ctx context.Context) (*autoupdate.AutoupdateConfig, error) { | ||
| resp, err := c.grpcClient.GetAutoupdateConfig(ctx, &autoupdate.GetAutoupdateConfigRequest{}) | ||
| return resp, trace.Wrap(err) | ||
| } | ||
|
|
||
| // CreateAutoupdateConfig creates a AutoupdateConfig. | ||
| func (c *Client) CreateAutoupdateConfig(ctx context.Context, config *autoupdate.AutoupdateConfig) (*autoupdate.AutoupdateConfig, error) { | ||
| resp, err := c.grpcClient.CreateAutoupdateConfig(ctx, &autoupdate.CreateAutoupdateConfigRequest{Config: config}) | ||
| return resp, trace.Wrap(err) | ||
| } | ||
|
|
||
| // UpdateAutoupdateConfig updates a AutoupdateConfig. | ||
| func (c *Client) UpdateAutoupdateConfig(ctx context.Context, config *autoupdate.AutoupdateConfig) (*autoupdate.AutoupdateConfig, error) { | ||
| resp, err := c.grpcClient.UpdateAutoupdateConfig(ctx, &autoupdate.UpdateAutoupdateConfigRequest{Config: config}) | ||
| return resp, trace.Wrap(err) | ||
| } | ||
|
|
||
| // UpsertAutoupdateConfig creates or updates a AutoupdateConfig. | ||
| func (c *Client) UpsertAutoupdateConfig(ctx context.Context, config *autoupdate.AutoupdateConfig) (*autoupdate.AutoupdateConfig, error) { | ||
| resp, err := c.grpcClient.UpsertAutoupdateConfig(ctx, &autoupdate.UpsertAutoupdateConfigRequest{Config: config}) | ||
| return resp, trace.Wrap(err) | ||
| } | ||
|
|
||
| // DeleteAutoupdateConfig removes the specified AutoupdateConfig resource. | ||
| func (c *Client) DeleteAutoupdateConfig(ctx context.Context) error { | ||
| _, err := c.grpcClient.DeleteAutoupdateConfig(ctx, &autoupdate.DeleteAutoupdateConfigRequest{}) | ||
| return trace.Wrap(err) | ||
| } | ||
|
|
||
| // GetAutoupdateVersion returns the specified AutoupdateVersion resource. | ||
| func (c *Client) GetAutoupdateVersion(ctx context.Context) (*autoupdate.AutoupdateVersion, error) { | ||
| resp, err := c.grpcClient.GetAutoupdateVersion(ctx, &autoupdate.GetAutoupdateVersionRequest{}) | ||
| return resp, trace.Wrap(err) | ||
| } | ||
|
|
||
| // CreateAutoupdateVersion creates a AutoupdateVersion. | ||
| func (c *Client) CreateAutoupdateVersion(ctx context.Context, config *autoupdate.AutoupdateVersion) (*autoupdate.AutoupdateVersion, error) { | ||
| resp, err := c.grpcClient.CreateAutoupdateVersion(ctx, &autoupdate.CreateAutoupdateVersionRequest{Version: config}) | ||
| return resp, trace.Wrap(err) | ||
| } | ||
|
|
||
| // UpdateAutoupdateVersion updates a AutoupdateVersion. | ||
| func (c *Client) UpdateAutoupdateVersion(ctx context.Context, config *autoupdate.AutoupdateVersion) (*autoupdate.AutoupdateVersion, error) { | ||
| resp, err := c.grpcClient.UpdateAutoupdateVersion(ctx, &autoupdate.UpdateAutoupdateVersionRequest{Version: config}) | ||
| return resp, trace.Wrap(err) | ||
| } | ||
|
|
||
| // UpsertAutoupdateVersion creates or updates a AutoupdateVersion. | ||
| func (c *Client) UpsertAutoupdateVersion(ctx context.Context, version *autoupdate.AutoupdateVersion) (*autoupdate.AutoupdateVersion, error) { | ||
| resp, err := c.grpcClient.UpsertAutoupdateVersion(ctx, &autoupdate.UpsertAutoupdateVersionRequest{Version: version}) | ||
| return resp, trace.Wrap(err) | ||
| } | ||
|
|
||
| // DeleteAutoupdateVersion removes the specified AutoupdateVersion resource. | ||
| func (c *Client) DeleteAutoupdateVersion(ctx context.Context) error { | ||
| _, err := c.grpcClient.DeleteAutoupdateVersion(ctx, &autoupdate.DeleteAutoupdateVersionRequest{}) | ||
| return trace.Wrap(err) | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should mention services in the api package since API does not an cannot depend on gravitational/teleport without creating an import cycle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, will remove this one, we have other 4 clients declaring the same