Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct postgres retention_period as a fragment instead of a GET param #46898

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Correct postgres retention_period as a fragment instead of a GET param #46898

merged 1 commit into from
Nov 19, 2024

Conversation

programmerq
Copy link
Contributor

@programmerq programmerq commented Sep 24, 2024 •
edited
Loading

When trying to use retention_period with a GET parameter in postgresql:// URI, this causes a failure.

server error (FATAL: unrecognized configuration parameter "retention_period" (SQLSTATE 42704))

Instead, the retention_period should be included as part of the fragment of the URI. Updating doc to show correct syntax.

@github-actions GitHub Actions
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-mseanxt31-goteleport.vercel.app/docs/ver/preview

@rosstimothy rosstimothy changed the title Remove incorrest postgres retention_period param Remove incorrect postgres retention_period param Sep 26, 2024
@github-actions GitHub Actions
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@zmb3 zmb3 requested a review from espadolini October 1, 2024 19:31
@programmerq
Correct postgres retention_period param syntax
961bc5b 
When trying to use `retention_period` query param with a `postgresql://` URI, this causes a failure.

`server error (FATAL: unrecognized configuration parameter "retention_period" (SQLSTATE 42704))`

The correct syntax is to include it in the fragment portion of the URI instead.
@programmerq programmerq force-pushed the jeff-doc-no-psql-retention branch from 81d6457 to 961bc5b Compare November 19, 2024 17:12
@programmerq
Copy link
Contributor Author

I was able to successfully set retention_period via a fragment. Adjusted and rebased the PR to correct the doc.

@programmerq programmerq changed the title Remove incorrect postgres retention_period param Correct postgres retention_period as a fragment instead of a GET param Nov 19, 2024
@programmerq programmerq added the no-changelog Indicates that a PR does not require a changelog entry label Nov 19, 2024
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-9ppmxwibe-goteleport.vercel.app/docs

@programmerq programmerq added this pull request to the merge queue Nov 19, 2024
Merged via the queue into master with commit 46e2fb2 Nov 19, 2024
40 of 43 checks passed
@programmerq programmerq deleted the jeff-doc-no-psql-retention branch November 19, 2024 19:07
@public-teleport-github-review-bot
Copy link

@programmerq See the table below for backport results.

Branch Result
branch/v15 Create PR
branch/v16 Create PR
branch/v17 Create PR

This was referenced Nov 19, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugoShaka hugoShaka hugoShaka approved these changes

@zmb3 zmb3 zmb3 approved these changes

@espadolini espadolini espadolini approved these changes

@ptgott ptgott Awaiting requested review from ptgott

Assignees
No one assigned
Labels
backport/branch/v15 backport/branch/v16 backport/branch/v17 documentation no-changelog Indicates that a PR does not require a changelog entry size/sm support-load This issue generates support load
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@programmerq @espadolini @zmb3 @hugoShaka @ptgott