Create WindowsDesktops for matching DynamicWindowsDesktops #46991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gister-resources-cache
…gister-resources-discovery
…register-resources-discovery
…r-resources-proto
…register-resources-api
greedy52
approved these changes
Oct 7, 2024
…r-resources-proto
…register-resources-api
…register-resources-config
…register-resources-config
…register-resources-api
…register-resources-discovery
Yes, I've added tests |
zmb3
approved these changes
Oct 18, 2024
public-teleport-github-review-bot
bot
removed the request for review
from hugoShaka
…gister-resources-cache
…r-resources-cache
…register-resources-discovery
Base automatically changed from
probakowski/register-resources-cache
to
master
October 22, 2024 21:40
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables Windows Desktop Services to create WindowsDesktops based on matching DynamicWindowsDesktops to allow dynamic registration. Matching will be done based on resource matchers added in #46985
This is part of splitting #46738 into smaller, easier to review, PRs
Closes #37103
changelog: Support dynamic registration for Windows desktops