Small refactor to attempt reconciliation code re-use between Azure & AWS integrations #47427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
mvbrock
added
the
no-changelog
jakule
approved these changes
Oct 11, 2024
tigrato
approved these changes
Oct 14, 2024
public-teleport-github-review-bot
bot
removed request for
vapopov and
nklaassen
Agree--I didn't mean to say we should re-use fields or anything like that. I originally had a reusable approach with an additional generic parameter and a few more functions passed as parameters, but it was ugly/complex. If I can't figure out a nice/simple way to make this reusable, then at least there's less lines to copy/borrow for Azure. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mvbrock
added a commit
that referenced
this pull request
Oct 16, 2024
…AWS integrations (#47427) * A little refactoring to attempt resuing reconciliation code between Azure & AWS integrations * Use "Wrap" instead of "Insert" * Removing my overly complex generic reconciler for now * A little more cleanup * PR feedback * Linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies some of the TAG AWS synchronization resource reconciliation for re-use with Azure integration. Specifically it introduces an wrapping function which wraps the original AWS item into the
AWSResourcetype.The eventual goal is to provide some simple upsert/delete reconciliation functionality that can be used across AWS, Azure, GCP, etc. While this PR does not directly accomplish this goal, it reduces some golang lines, and simplifies the reconciliation towards a basic process: