Remove nested tabs from docs pages #47862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
hugoShaka,
mmcallister,
nklaassen,
r0mant,
ravicious,
xinding33 and
zmb3
ptgott
added
no-changelog
zmb3
approved these changes
Oct 23, 2024
|
Where's the amplify bot when we need a preview? 😭 |
The Vercel build failed as well, so I'm guessing I messed up the syntax somewhere 🙃 |
Closes #35870 Used the following command to find nested tabs: ``` $ find docs/pages -name "*.mdx" -exec awk ' /<TabItem/{ti=1} ti==1 && /<\/TabItem/{ti=0} ti==1 && /<Tabs/{n=1;if(lines=="") lines=FNR; else lines=(lines "," FNR)} END{if(n>0) print FILENAME ":" lines}' {} \; ``` Edit the following guides: - **Connect your Client intro:** Remove branching between Community Edition and Teleport Enterprise. The only difference was the assumption that Community Edition users would only have a GitHub connector available. But if users must ask their administrator for an SSO connector name anyway, we don't need to specify the connector name here. - **GUI clients:** Use separate H4s to describe using a local proxy server and getting remote host information. - **Self-Signed Certs:** Don't use tabs to explain the difference in syntax between using `--set` and a values file in Helm. Instead, use inline prose. - **Locking:** Explain both the CAP and static config file in the "Self-Hosted" tab. - **AWS Helm deployment:** Remove the Community Edition tab in Step 5 and explain how to disable the `enterprise` field using a YAML comment - **Kubernetes AWS auto-discovery:** Collapse `aws-auth` and `eks create-access-entry` instructions into a single passage of text.
ptgott
force-pushed
the
paul.gottschling/35870-tabs
branch
from
ab20ee6 to
a97ea0e
Compare
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
🤖 Vercel preview here: https://docs-p4o66ssgf-goteleport.vercel.app/docs/ver/preview |
stevenGravy
approved these changes
Oct 29, 2024
mmcallister
reviewed
Oct 29, 2024
mmcallister
approved these changes
Oct 29, 2024
public-teleport-github-review-bot
bot
removed request for
ravicious,
r0mant,
hugoShaka,
nklaassen and
xinding33
|
🤖 Vercel preview here: https://docs-dx8wmroxh-goteleport.vercel.app/docs/ver/preview |
This was referenced Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35870
Used the following command to find nested tabs:
Edit the following guides:
--setand a values file in Helm. Instead, use inline prose.enterprisefield using a YAML commentaws-authandeks create-access-entryinstructions into a single passage of text.