ha-autoscale-cluster: Source unit file environment variables from /etc/default/teleport #48040
Conversation
…c/default/teleport
webvictim
added
terraform-deployment-examples
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
| @@ -14,3 +14,8 @@ TELEPORT_ENABLE_POSTGRES=${enable_postgres_listener} | |||
| USE_ACM=${use_acm} | |||
| USE_TLS_ROUTING=${use_tls_routing} | |||
| EOF | |||
| cat >>/etc/default/teleport <<EOF | |||
There was a problem hiding this comment.
Is /etc/teleport.d/conf also necessary?
There was a problem hiding this comment.
Yeah, that file is sourced all over the place.
I could theoretically rewrite all the places it's used to use /etc/default/teleport instead, but setting a lot of extra environment variables in the environment file Teleport itself sources might have unintended consequences. It'd also be a huge PR that would need a lot of testing.
At the moment there's a relatively clean split between "environment variables used by Teleport" and "environment variables used by the AMI/unit files".
hugoShaka
removed
the
no-changelog
public-teleport-github-review-bot
bot
removed the request for review
from klizhentas
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
@webvictim See the table below for backport results.
|
This removes some deprecated code scheduled for cleanup in 17.0.0.
Tested by deploying
ha-autoscale-clusterwith local 16.4.6 OSS and Enterprise AMI builds.Changelog: Teleport AMIs no longer source
/etc/teleport.d/confin the Proxy Service systemd unit. Use/etc/default/teleportif you want to set Proxy Service environment variables.