Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16] [kube] add server_id to targets when monitoring exec/portforward connections #48076

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

tigrato
Copy link
Contributor

@tigrato tigrato commented Oct 29, 2024

Backport #47829 to branch/v16

@tigrato tigrato added the no-changelog Indicates that a PR does not require a changelog entry label Oct 29, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-48076.d212ksyjt6y4yg.amplifyapp.com

@tigrato tigrato enabled auto-merge October 29, 2024 15:47
…ections

This PR adds the target server_id (kubernetes service) when proxy establishes a connection to support kubectl exec and portforward. This allows proxies to terminate early the connection without relying on the upstream to terminate it.
@tigrato tigrato force-pushed the bot/backport-47829-branch/v16 branch from 1b2d7e1 to 2630f4f Compare October 29, 2024 17:07
@tigrato tigrato added this pull request to the merge queue Oct 29, 2024
Merged via the queue into branch/v16 with commit 73949ce Oct 29, 2024
40 checks passed
@tigrato tigrato deleted the bot/backport-47829-branch/v16 branch October 29, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport kubernetes-access no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants