Bump typescript-eslint from 7.14.1 to 8.12.2 #48275
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint) from 7.14.1 to 8.12.2. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.12.2/packages/typescript-eslint) --- updated-dependencies: - dependency-name: typescript-eslint dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
dependabot
bot
requested review from
avatus,
bl-nero,
gzdunek,
kimlisa,
ravicious,
rudream and
ryanclark
| @@ -88,6 +88,11 @@ module.exports = { | |||
| 'import/no-unresolved': 0, | |||
| 'no-unused-vars': 'off', // disabled to allow the typescript one to take over and avoid errors in reporting | |||
| '@typescript-eslint/no-unused-vars': ['error'], | |||
| 'no-unused-expressions': 'off', | |||
| '@typescript-eslint/no-unused-expressions': [ | |||
There was a problem hiding this comment.
@rudream no-unused-expressions complains about this line and one below it that simply attempts to read the property. Is reading the property alone enough to force reflow?
There was a problem hiding this comment.
Is reading the property alone enough to force reflow?
yes, it causes the recalculation.
i just prepended void (as found recommended online) and it causes the error to go away
| { | ||
| files: ['**/*.js'], | ||
| rules: { | ||
| '@typescript-eslint/no-require-imports': 'warn', |
There was a problem hiding this comment.
I tried replacing requires with imports everywhere (it's on r7s/esm), but I couldn't get Babel to work with Jest.
There was a problem hiding this comment.
I currently have a branch trying to upgrade eslint to v9 and all the dependencies have required a massive change. We can table this one until I'm able to carve out enough time this quarter to finally tackle it.
There was a problem hiding this comment.
Wouldn't it be better if this particular update was already taken care of? Then the final PR will be smaller.
There was a problem hiding this comment.
And we wouldn't risk introducing new lint issues.
|
Lets see how CI reacts, but after my commit, locally all tests and lint passes |
|
This requires a buddy PR in e, I'll prepare it in a sec. |
public-teleport-github-review-bot
bot
removed request for
ryanclark,
bl-nero,
gzdunek,
kimlisa and
rudream
ravicious
deleted the
dependabot/npm_and_yarn/typescript-eslint-8.12.2
branch
Bumps typescript-eslint from 7.14.1 to 8.12.2.
Release notes
Sourced from typescript-eslint's releases.
... (truncated)
Changelog
Sourced from typescript-eslint's changelog.
... (truncated)
Commits
4af866achore(release): publish 8.12.21edec1dchore(release): publish 8.12.13413a2dchore(release): publish 8.12.0ad9d3bafeat(typescript-eslint): improve undefined extension handling (#10177)79c27a8chore(release): publish 8.11.07effdeachore(release): publish 8.10.0be5bc0ffix(typescript-eslint): propagatenamefield to extended configs in `config...4666ed4chore(release): publish 8.9.0f898248chore(release): publish 8.8.12055cfbchore(release): publish 8.8.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)