-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump typescript-eslint from 7.14.1 to 8.12.2 #48275
Changes from all commits
be7d9fd
425d142
fb725d4
0a272ab
0aacd6b
49bdefb
916b4bf
3a3b9bd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -65,6 +65,14 @@ module.exports = { | |||
'jest/no-large-snapshots': ['warn', { maxSize: 200 }], | ||||
}, | ||||
}, | ||||
// Allow require imports in .js files, as migrating our project to ESM modules requires a lot of | ||||
// changes. | ||||
{ | ||||
files: ['**/*.js'], | ||||
rules: { | ||||
'@typescript-eslint/no-require-imports': 'warn', | ||||
}, | ||||
}, | ||||
], | ||||
rules: { | ||||
'import/order': [ | ||||
|
@@ -88,6 +96,16 @@ module.exports = { | |||
'import/no-unresolved': 0, | ||||
'no-unused-vars': 'off', // disabled to allow the typescript one to take over and avoid errors in reporting | ||||
'@typescript-eslint/no-unused-vars': ['error'], | ||||
'no-unused-expressions': 'off', | ||||
'@typescript-eslint/no-unused-expressions': [ | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @rudream no-unused-expressions complains about this line and one below it that simply attempts to read the property. Is reading the property alone enough to force reflow?
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
yes, it causes the recalculation. |
||||
'error', | ||||
{ allowShortCircuit: true, allowTernary: true, enforceForJSX: true }, | ||||
], | ||||
'@typescript-eslint/no-empty-object-type': [ | ||||
'error', | ||||
// with-single-extends is needed to allow for interface extends like we have in jest.d.ts. | ||||
{ allowInterfaces: 'with-single-extends' }, | ||||
], | ||||
|
||||
// Severity should be one of the following: | ||||
// "off" or 0 - turn the rule off | ||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried replacing requires with imports everywhere (it's on
r7s/esm
), but I couldn't get Babel to work with Jest.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I currently have a branch trying to upgrade eslint to v9 and all the dependencies have required a massive change. We can table this one until I'm able to carve out enough time this quarter to finally tackle it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be better if this particular update was already taken care of? Then the final PR will be smaller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And we wouldn't risk introducing new lint issues.