Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16] Improve 'Please run' messages in the CI #48410

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

hugoShaka
Copy link
Contributor

Manual backport of #48365 to branch/v16.

* Improve 'Please run error'

* add missing file

* fix script

* Apply suggestions from code review

Co-authored-by: Alan Parra <alan.parra@goteleport.com>

* address alan's feedback

* Update Makefile

Co-authored-by: Alan Parra <alan.parra@goteleport.com>

* Update build.assets/please-run.sh

Co-authored-by: Alan Parra <alan.parra@goteleport.com>

---------

Co-authored-by: Alan Parra <alan.parra@goteleport.com>
@hugoShaka hugoShaka changed the title Improve 'Please run' messages in the CI (#48365) [v16] Improve 'Please run' messages in the CI Nov 4, 2024
@hugoShaka hugoShaka added the no-changelog Indicates that a PR does not require a changelog entry label Nov 4, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-48410.d212ksyjt6y4yg.amplifyapp.com

@hugoShaka hugoShaka added this pull request to the merge queue Nov 5, 2024
Merged via the queue into branch/v16 with commit 92c2b9a Nov 5, 2024
43 of 45 checks passed
@hugoShaka hugoShaka deleted the hugo/backport-48365-to-branch/v16 branch November 5, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants