Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[entraid] ask for mfa reuse during entraid plugin setup #48493

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

tigrato
Copy link
Contributor

@tigrato tigrato commented Nov 5, 2024

This PR fixes a bug where MFA for admin actions prevents creating multiple objects during the entra id setup guide.

Part of #48485

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-48493.d3pp5qlev8mo18.amplifyapp.com

@tigrato tigrato force-pushed the tigrato/fix-entra-mfa-reuse branch from a3f4640 to 0d44107 Compare November 6, 2024 09:32
@tigrato tigrato marked this pull request as ready for review November 6, 2024 09:39
@tigrato tigrato added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v16 backport/branch/v17 labels Nov 6, 2024
@github-actions github-actions bot added size/sm tctl tctl - Teleport admin tool labels Nov 6, 2024
@tigrato tigrato force-pushed the tigrato/fix-entra-mfa-reuse branch from cfd8aec to 0d44107 Compare November 6, 2024 10:43
This PR fixes a bug where MFA for admin actions prevents creating
multiple objects during the entra id setup guide.

Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
@tigrato tigrato force-pushed the tigrato/fix-entra-mfa-reuse branch from 0d44107 to 1d9be37 Compare November 6, 2024 10:44
@tigrato tigrato enabled auto-merge November 6, 2024 10:47
@tigrato tigrato added this pull request to the merge queue Nov 6, 2024
Merged via the queue into master with commit ee1726e Nov 6, 2024
40 checks passed
@tigrato tigrato deleted the tigrato/fix-entra-mfa-reuse branch November 6, 2024 11:20
@public-teleport-github-review-bot

@tigrato See the table below for backport results.

Branch Result
branch/v16 Create PR
branch/v17 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v16 backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/sm tctl tctl - Teleport admin tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants