Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix "make create-github-release" #49111

Merged
merged 2 commits into from
Nov 19, 2024
Merged

build: Fix "make create-github-release" #49111

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b76090c
build: Fix "make create-github-release"
camscale Nov 16, 2024
bdb0ef6
build: Remove single-use vars for simplicity
camscale Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1809,10 +1809,10 @@ rustup-install-target-toolchain: rustup-set-version
# usage: BASE_BRANCH=branch/v13 BASE_TAG=v13.2.0 make changelog
#
# BASE_BRANCH and BASE_TAG will be automatically determined if not specified.
CHANGELOG = github.com/gravitational/shared-workflows/tools/changelog@latest
.PHONY: changelog
changelog:
@go run $(CHANGELOG) --base-branch="$(BASE_BRANCH)" --base-tag="$(BASE_TAG)" ./
@go run github.com/gravitational/shared-workflows/tools/changelog@latest \
--base-branch="$(BASE_BRANCH)" --base-tag="$(BASE_TAG)" ./

# create-github-release will generate release notes from the CHANGELOG.md and will
# create release notes from them.
Expand All @@ -1826,12 +1826,14 @@ changelog:
#
# For more information on release notes generation see:
# https://github.com/gravitational/shared-workflows/tree/gus/release-notes/tools/release-notes#readme
RELEASE_NOTES_GEN = github.com/gravitational/shared-workflows/tools/release-notes@latest
.PHONY: create-github-release
create-github-release: LATEST = false
create-github-release: GITHUB_RELEASE_LABELS = ""
create-github-release:
@NOTES=$$($(RELEASE_NOTES_GEN) --labels=$(GITHUB_RELEASE_LABELS) $(VERSION) CHANGELOG.md) && gh release create v$(VERSION) \
@NOTES=$$( \
go run github.com/gravitational/shared-workflows/tools/release-notes@latest \
--labels=$(GITHUB_RELEASE_LABELS) $(VERSION) CHANGELOG.md \
) && gh release create v$(VERSION) \
-t "Teleport $(VERSION)" \
--latest=$(LATEST) \
--verify-tag \
Expand Down
Loading