Extend hostid test backoff #49193
Merged
Extend hostid test backoff #49193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempts to reduce any flakiness caused by contention producing a host id by allowing tests to use a longer exponential backoff and retrying more times.
rosstimothy
added
no-changelog
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
This branch passed the following test, prior to this I was only able to get docker run --cpus="0.01" -vteleport:/teleport golang:1.22.4-bookworm /teleport/hostid.test -test.count=1000 -test.timeout=60m -test.failfast -test.v -test.run "TestReadOrCreate" |
fspmarshall
approved these changes
Nov 19, 2024
zmb3
approved these changes
Nov 19, 2024
public-teleport-github-review-bot
bot
removed request for
gabrielcorado and
strideynet
|
@rosstimothy See the table below for backport results.
|
rosstimothy
added a commit
that referenced
this pull request
Nov 19, 2024
Attempts to reduce any flakiness caused by contention producing a host id by allowing tests to use a longer exponential backoff and retrying more times.
rosstimothy
added a commit
that referenced
this pull request
Nov 19, 2024
Attempts to reduce any flakiness caused by contention producing a host id by allowing tests to use a longer exponential backoff and retrying more times.
rosstimothy
added a commit
that referenced
this pull request
Nov 19, 2024
Attempts to reduce any flakiness caused by contention producing a host id by allowing tests to use a longer exponential backoff and retrying more times.
rosstimothy
added a commit
that referenced
this pull request
Nov 19, 2024
Attempts to reduce any flakiness caused by contention producing a host id by allowing tests to use a longer exponential backoff and retrying more times.
rosstimothy
added a commit
that referenced
this pull request
Nov 19, 2024
Attempts to reduce any flakiness caused by contention producing a host id by allowing tests to use a longer exponential backoff and retrying more times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to reduce any flakiness caused by contention producing a host id by allowing tests to use a longer exponential backoff and retrying more times. #48903 improved the backoff, but it proved to still be not enough to satisfy the nightly flake finder.