Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16] improve error message when v16 tctl reads v17 tsh profile #49306

Merged

Conversation

nklaassen
Copy link
Contributor

# before
$ tctl status
ERROR: your credentials have expired, please login using `tsh login`

# after
$ go run ./tool/tctl status
ERROR: it appears tsh v17 or newer was used to log in, make sure to use tsh and tctl on the same major version
        no credentials: user TLS certificate was found at unsupported v17+ path (expected path: /Users/nic/.tsh/keys/one.private/nic-x509.pem, found path: /Users/nic/.tsh/keys/one.private/nic.crt)

exit status 1

This is almost a backport of #49305 but it inverts the comparison so that v16 tctl (versions after this merges) has a better error message when trying to read a profile created by tsh v17

@github-actions github-actions bot added backport size/sm tctl tctl - Teleport admin tool labels Nov 21, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-49306.d212ksyjt6y4yg.amplifyapp.com

@nklaassen nklaassen enabled auto-merge November 21, 2024 21:05
@nklaassen nklaassen added the no-changelog Indicates that a PR does not require a changelog entry label Nov 21, 2024
@nklaassen nklaassen added this pull request to the merge queue Nov 21, 2024
Merged via the queue into branch/v16 with commit 3b3c274 Nov 21, 2024
43 of 44 checks passed
@nklaassen nklaassen deleted the nklaassen/v16/nklaassen/tctl-profile-version-check branch November 21, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport no-changelog Indicates that a PR does not require a changelog entry size/sm tctl tctl - Teleport admin tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants