[teleport-update] Protect against disk space leaks #49309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sclevine
added
the
no-changelog
zmb3
approved these changes
Nov 21, 2024
vapopov
approved these changes
Nov 22, 2024
sclevine
force-pushed
the
sclevine/teleport-update-orphans
branch
from
3e2d32d to
7275296
Compare
public-teleport-github-review-bot
bot
removed request for
r0mant,
hugoShaka and
gzdunek
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that
teleport-updateremoves installations of Teleport that are no longer referenced by its configuration (update.yaml) or linked into/usr/local/bin.Note that the logic avoids removing partially linked installations that are no longer referenced by configuration. This case could occur if a Teleport binary is removed in newer versions of Teleport, as
teleport-updateonly atomically replaces (and never deletes) symlinks.The
teleport-updatebinary will be used to enable, disable, and trigger automatic Teleport agent updates. The new auto-updates system manages a local installation of the cluster-specified version of Teleport stored in/var/lib/teleport/versions.RFD: #47126
Goal (internal): https://github.com/gravitational/cloud/issues/10289