Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v17] Add ListDevicesByUser protos #49328

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

avatus
Copy link
Contributor

@avatus avatus commented Nov 21, 2024

Backport #48993 and #49209

These support the upcoming service to allow users to see a list of their
own registered devices in the web UI account settings page.
Originally, we included the `View` field in order to add the Owner
property to safeguard the returned details of a device ensure the owner
matched the caller. However, this ended up not being conditionally used
(we would never _not_ use it) so we can remove it from the request.
@avatus avatus added the no-changelog Indicates that a PR does not require a changelog entry label Nov 21, 2024
@github-actions github-actions bot requested review from codingllama and zmb3 November 21, 2024 15:54
@avatus avatus added this pull request to the merge queue Nov 21, 2024
Merged via the queue into branch/v17 with commit 5110ae3 Nov 21, 2024
46 of 47 checks passed
@avatus avatus deleted the avatus/v17/device-protos branch November 21, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants