New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate AWS RDS services to AWS SDK v2 #50848

Merged

GavinFrazar merged 1 commit into master from gavinfrazar/migrate-rds-to-sdk-v2

Jan 10, 2025

Contributor

GavinFrazar commented Jan 8, 2025 •

edited

Loading

This PR migrates all uses of AWS RDS API to AWS SDK v2.

This PR depends on and is stacked on top of another PR:

Simplify awsconfig loading #50809

Part of #14142

Migrate from aws-sdk-go to aws-sdk-go-v2 #14142

GavinFrazar force-pushed the gavinfrazar/migrate-rds-to-sdk-v2 branch from 1e6df12 to 6f88eaa Compare

January 8, 2025 00:24

GavinFrazar commented

View reviewed changes

lib/cloud/aws/tags_helpers_test.go Show resolved Hide resolved

GavinFrazar commented

View reviewed changes

lib/cloud/aws/tags_helpers.go Show resolved Hide resolved

GavinFrazar commented

View reviewed changes

lib/srv/db/cloud/meta.go Show resolved Hide resolved

GavinFrazar commented

View reviewed changes

lib/srv/db/watcher_test.go Show resolved Hide resolved

GavinFrazar commented

View reviewed changes

lib/srv/discovery/fetchers/db/aws_docdb.go Show resolved Hide resolved

GavinFrazar commented

View reviewed changes

lib/srv/discovery/fetchers/db/aws_rds.go Show resolved Hide resolved

GavinFrazar force-pushed the gavinfrazar/migrate-rds-to-sdk-v2 branch from 6f88eaa to bc8d624 Compare

January 8, 2025 01:15

GavinFrazar marked this pull request as ready for review

January 8, 2025 01:24

github-actions bot added database-access discovery size/md labels

github-actions bot requested review from bernardjkim, greedy52, hugoShaka and tigrato

January 8, 2025 01:25

GavinFrazar added the no-changelog label

greedy52 requested a review from gabrielcorado

January 8, 2025 16:48

greedy52 reviewed

View reviewed changes

lib/srv/db/cloud/aws.go Show resolved Hide resolved

lib/srv/discovery/fetchers/aws-sync/rds.go Show resolved Hide resolved

lib/srv/discovery/fetchers/db/aws_docdb.go Show resolved Hide resolved

Base automatically changed from gavinfrazar/simplify-aws-config-loading to master

January 8, 2025 18:38

GavinFrazar force-pushed the gavinfrazar/migrate-rds-to-sdk-v2 branch 2 times, most recently from c8b7f0c to 6d9f2e0 Compare

January 8, 2025 19:15

greedy52 approved these changes

View reviewed changes

GavinFrazar force-pushed the gavinfrazar/migrate-rds-to-sdk-v2 branch from 6d9f2e0 to 9394dc9 Compare

January 8, 2025 23:35

tigrato approved these changes

View reviewed changes

public-teleport-github-review-bot bot removed request for gabrielcorado, bernardjkim and hugoShaka

January 9, 2025 19:52

GavinFrazar force-pushed the gavinfrazar/migrate-rds-to-sdk-v2 branch from 9394dc9 to 46e7240 Compare

January 10, 2025 21:38


          migrate AWS RDS services to AWS SDK v2

37a71fe

GavinFrazar force-pushed the gavinfrazar/migrate-rds-to-sdk-v2 branch from 46e7240 to 37a71fe Compare

January 10, 2025 22:02

GavinFrazar added this pull request to the merge queue

GavinFrazar added the aws label

GavinFrazar mentioned this pull request

migrate AWS Redshift Serverless to AWS SDK v2 #50964

Open

Merged via the queue into master with commit aa34c34

45 checks passed

GavinFrazar deleted the gavinfrazar/migrate-rds-to-sdk-v2 branch

January 10, 2025 22:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws database-access discovery no-changelog size/md