[chore] remove github.com/xanzy/go-gitlab from direct depenencies
#50857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After deprecation of `github.com/xanzy/go-gitlab` in favour of `gitlab.com/gitlab-org/api/client-go`, this PR drops the direct dependency from Teleport module. The dependency is still indirect because it's imported by `cosign`. Hopefully in future versions, the dependency will be updated and fully removed. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato
added
the
no-changelog
ryanclark
approved these changes
Jan 8, 2025
kopiczko
approved these changes
Jan 8, 2025
public-teleport-github-review-bot
bot
removed request for
bernardjkim and
hugoShaka
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the deprecation of github.com/xanzy/go-gitlab in favor of gitlab.com/gitlab-org/api/client-go, this PR removes the direct dependency from the Teleport module. However, the dependency remains indirectly included through cosign. hopefully, future versions will update and completely eliminate this dependency.