Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4.x] migrate dictionaries event with latest start or stop publish or unpublish state #9152

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 20, 2024

This is an automatic copy of pull request #9129 done by Mergify.


Issue

https://gravitee.atlassian.net/browse/APIM-6914

Description

Today when we migrate the dictionaries from event to event_latest ( APIM 3.20 to 4.x ) only the last event is migrated. The problem is that if the last event is not a PUBLISH_DICTIONARY we can lose a dictionary on gateway side after the migration. For example a dictionary can pass from published and stoped to only stoped.

Additional context


Cherry-pick of cae1d15 has failed:

On branch mergify/bp/4.4.x/pr-9129
Your branch is up to date with 'origin/4.4.x'.

You are currently cherry-picking commit cae1d1561e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   gravitee-apim-rest-api/gravitee-apim-rest-api-service/src/main/java/io/gravitee/rest/api/service/EventService.java
	modified:   gravitee-apim-rest-api/gravitee-apim-rest-api-service/src/main/java/io/gravitee/rest/api/service/impl/upgrade/upgrader/EventsLatestUpgrader.java
	modified:   gravitee-apim-rest-api/gravitee-apim-rest-api-service/src/test/java/io/gravitee/rest/api/service/impl/upgrade/upgrader/EventsLatestUpgraderTest.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   gravitee-apim-rest-api/gravitee-apim-rest-api-service/src/main/java/io/gravitee/rest/api/service/impl/EventServiceImpl.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested a review from a team as a code owner September 20, 2024 15:43
@mergify mergify bot added the conflicts label Sep 20, 2024
Copy link
Contributor Author

mergify bot commented Sep 20, 2024

Cherry-pick of cae1d15 has failed:

On branch mergify/bp/4.4.x/pr-9129
Your branch is up to date with 'origin/4.4.x'.

You are currently cherry-picking commit cae1d1561e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   gravitee-apim-rest-api/gravitee-apim-rest-api-service/src/main/java/io/gravitee/rest/api/service/EventService.java
	modified:   gravitee-apim-rest-api/gravitee-apim-rest-api-service/src/main/java/io/gravitee/rest/api/service/impl/upgrade/upgrader/EventsLatestUpgrader.java
	modified:   gravitee-apim-rest-api/gravitee-apim-rest-api-service/src/test/java/io/gravitee/rest/api/service/impl/upgrade/upgrader/EventsLatestUpgraderTest.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   gravitee-apim-rest-api/gravitee-apim-rest-api-service/src/main/java/io/gravitee/rest/api/service/impl/EventServiceImpl.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

…unpublish state

(cherry picked from commit cae1d15)

(cherry picked from commit 86a941e)
@Okhelifi Okhelifi merged commit 12f0984 into 4.4.x Sep 23, 2024
15 checks passed
@Okhelifi Okhelifi deleted the mergify/bp/4.4.x/pr-9129 branch September 23, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant