Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential fix for issue #277 #281

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Potential fix for issue #277 #281

wants to merge 1 commit into from

Conversation

DarkArc
Copy link

@DarkArc DarkArc commented Mar 22, 2014

Also corrected a typo where fast place was using the count of the fast break check in its output.

This is not tested, but it may resolve the issue.

Also corrected a typo where fast place was using the count of the fast break check in its output
@DarkArc DarkArc mentioned this pull request Mar 22, 2014
@drtshock
Copy link

drtshock commented Jul 9, 2014

Did you test this? Pulling "potential fixes" is not a good idea for a large project.

@DarkArc
Copy link
Author

DarkArc commented Jul 9, 2014

No, and I actually said that in the PR description... I don't have a hack client to properly test this. However, what I can say is that the check I removed is only false when there has been no delay between the last block and the current block. Additionally, because of the behavior of some systems the time may be incremented in variants that do not provide milli second accuracy. Thus increasing the likely hood of this check being problematic on some systems.

@gravitylow
Copy link
Owner

I feel like that was specific enough that I added it on purpose, but for the life of me I can't come up with a reason why.

@DarkArc
Copy link
Author

DarkArc commented Jul 10, 2014

I definitely thought it was odd. It seems like the most likely cause of the issue though imo. Either way, it gives you something to look at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants