Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with 'Open Code Chest' link on a sub site redirecting back to the main site. #1

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

saifsultanc
Copy link
Contributor

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2530550446/62739?folderId=7098280

Summary

Open Code Chest link on the subsite in multi-site installation opens to the main site with a form of the same ID.

The issue and the fix for it:
https://www.loom.com/share/690e1c10afd148bdb20d76d1d8a9af7d

Checklist

  • Updated customer telling them that a fix/addition is in the works.
  • Added/Improved Cypress tests or a note under Summary why tests are not included in the PR.
  • Added a link to this PR in the Help Scout ticket(s) in the form of a note
  • Added/updated hook documentation if applicable.
  • Sent a packed build of this PR/branch for the customer to test.

@saifsultanc saifsultanc added the bug Something isn't working label Mar 6, 2024
Copy link
Contributor

@claygriffiths claygriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be able to be further simplified. See my suggestions

class-gwiz-gf-code-chest.php Outdated Show resolved Hide resolved
class-gwiz-gf-code-chest.php Outdated Show resolved Hide resolved
saifsultanc and others added 2 commits March 7, 2024 14:52
Co-authored-by: Clay Griffiths <clay@claygriffiths.com>
Copy link
Contributor

@claygriffiths claygriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@saifsultanc saifsultanc merged commit dbe31f9 into main Mar 8, 2024
1 check passed
@saifsultanc saifsultanc deleted the saif/fix/62739-fix-code-chest-link-multisite branch March 8, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants