Fixed an issue where css comment is parsed as a css rule #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claygriffiths
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
LGTM, tested with https://regex101.com/r/g4XBJX/1
The previous regex looks like... https://regex101.com/r/Fg3RA7/1
Squash and merge with
Fixed issue where CSS comments containing a comma would be prefixed incorrectly, which could cause syntax errors in the CSS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2544175554/63516
Summary
When the character
,is used in CSS comment. The CSS comment is parsed as a CSS rule, hence the issue. This PR should fix the issue.