Fixed issue with gform_post_save_feed_settings hook callback that potentially breaks othe
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otentially breaks other plugins.
claygriffiths
force-pushed
the
matt/fix-gform_post_save_feed_settings
branch
from
077b437
to
be979a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The callback for
gform_post_save_feed_settingswas running no matter which plugin class instance was gettig passed. This could cause issues with custom settings in other plugins for the given feed from other plugins.Specifically, I was running into issues with this overwriting custom feed settings that GCN was saving.